[Asterisk-code-review] res_stir_shaken: Do not build without OpenSSL. (asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15027 )

Change subject: res_stir_shaken: Do not build without OpenSSL.
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review-1
> 
> Thank you to CC me. However, this is a bit over my top. I do not understand it yet. This is a backport from master/18 to 16, right? Furthermore, this new feature/module(s) got completed since my last commit. However, the header res_stir_shaken.h does not use any symbol of OpenSSL. Right? Back then, when I committed in April, everything was a stub. Today, it is (just) res_stir_shaken.c which is using OpenSSL. Right? In that case, shouldn’t the two OpenSSL headers be moved from res_stir_shaken.h to res_stir_shaken.c?
> 
> That would avoid the dependency on OpenSSL in the module res_pjsip_stir_shaken.

Gerrit automatically CCed various involved people. This is a series of cherry picks from 18 and matches the code already in place in 18. If there's any issues, they should go into a new commit that can then be cherry picked.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15027
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Idba5151a3079f9dcc0076d635422c5df5845114f
Gerrit-Change-Number: 15027
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Fri, 02 Oct 2020 16:15:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201002/d7ef4172/attachment.html>