[Asterisk-code-review] Introduce astcachedir, to be used for temporary bucket files (asterisk[16])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15076 )

Change subject: Introduce astcachedir, to be used for temporary bucket files
......................................................................


Patch Set 2:

> Patch Set 2:
> 
> > Patch Set 1: Code-Review-1
> > 
> > Needs a CHANGES entry I think.  Other than that, I'm OK with this for 16 and 18.  For master, I'd make the default LOCALSTATEDIR/cache/asterisk (/var/cache/asterisk) and update the Makefile to create that directory on install if needed and remove it on uninstall-all (not plain uninstall).
> 
> I added an entry for CHANGES, and will cherry-pick to 18.
> 
> Should this be cherry-picked to master as well and then switched to /var/ in a separate change request?

You can do it that way if you like (if you do be sure to reference the same issue).

I would suggest though just cherry-picking the patch locally, make the changes, and then push the patch for review. The branches will have the same change-id, but the master branch patch will be slightly different.

Either route you choose be sure to also update (or add a new one) the CHANGES to make not of the default changing.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15076
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ic54e95199405abacd9e509cef5f08fa14c510b5d
Gerrit-Change-Number: 15076
Gerrit-PatchSet: 2
Gerrit-Owner: lvl <digium at lvlconsultancy.nl>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 12 Nov 2020 18:17:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201112/1bae0f4b/attachment.html>