[Asterisk-code-review] chan_sip: Remove unused sip_socket->port. (asterisk[16])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15143 )

Change subject: chan_sip: Remove unused sip_socket->port.
......................................................................


Patch Set 1: Code-Review-1

I'm a little leery of changing the structure at this point in the life of chan_sip.  Even though it's a private structure, lots of people have hacked on chan_sip and may not expect the change.  We'd then be faced with having to do more work on an extended support/deprecated module.

I also don't understand how this fixes ASTERISK-28798.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15143
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ib90516a49eca3d724a70191278aaf2144fb58c59
Gerrit-Change-Number: 15143
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 09 Nov 2020 14:09:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201109/b9ea98d4/attachment-0001.html>