[Asterisk-code-review] chan_sip: Remove unused sip_socket->port. (asterisk[master])
Alexander Traud
asteriskteam at digium.com
Wed Nov 4 07:51:13 CST 2020
Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15137 )
Change subject: chan_sip: Remove unused sip_socket->port.
......................................................................
Patch Set 1:
Because of this, the size of the struct sip_socket and struct sip_pvt change. However, as these are private structs, I do not think anyone is harmed. If there are concerns, I can leave the struct member and remove just the code in chan_sip.c.
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15137
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ib90516a49eca3d724a70191278aaf2144fb58c59
Gerrit-Change-Number: 15137
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-CC: Friendly Automation
Gerrit-Comment-Date: Wed, 04 Nov 2020 13:51:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201104/ace39141/attachment-0001.html>
More information about the asterisk-code-review
mailing list