[Asterisk-code-review] res_pjsip_outbound_registration.c: Use our own scheduler and other s... (asterisk[16])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15130 )

Change subject: res_pjsip_outbound_registration.c:  Use our own scheduler and other stuff
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/15130/2/res/res_pjsip_outbound_registration.c 
File res/res_pjsip_outbound_registration.c:

https://gerrit.asterisk.org/c/asterisk/+/15130/2/res/res_pjsip_outbound_registration.c@544 
PS2, Line 544: pjsip_regc_info info;
             : 
             : 	pjsip_regc_get_info(client_state->client, &info);
             : 
             : 	callback_invoked = ast_threadstorage_get(&register_callback_invoked, sizeof(int));
             : 	if (!callback_invoked) {
             : 		pjsip_tx_data_dec_ref(tdata);
             : 		ast_log(LOG_ERROR, "Failed to get threadstorage for registration to server '%.*s' from client '%.*s'\n",
             : 				(int) info.server_uri.slen, info.server_uri.ptr,
             : 				(int) info.client_uri.slen, info.client_uri.ptr);
> Since info is really only used here in off nominal paths maybe only retrieve it when that happens?

Actually, I think I'm going to remove the calls to pjsip_regc_get_info altogether.  I'm going to add the URLs to the client state so they can be used everywhere.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15130
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I4534a0fc78c7cb69f23b7b449dda9748c90daca2
Gerrit-Change-Number: 15130
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 04 Nov 2020 13:47:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201104/bd4f5771/attachment.html>