[Asterisk-code-review] loader: Sync load- and build-time deps. (asterisk[18])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15119 )

Change subject: loader: Sync load- and build-time deps.
......................................................................


Patch Set 2:

> Patch Set 2:
> 
> What does that mean for this change (and/or me):
> 1) Is there a way to avoid sorcery_astdb and/or sorcery_config?
> 2) If you do not know the way for sure and it is a hypothesis, what could I try to test this hypothesis; any idea?
> 3) What about the depend/require mismatch of build-time and runtime then?
> The problem, I do not know what to change. The idea is: Each depend has to end up in .requires. Is that not correct?

I assume you could use res_sorcery_realtime in place of config / astdb.  This is outside my area of knowledge though so I can't give advice on how to test with this setup.  On the hypothetical side someone could have created a res_sorcery_redis or other module that is not submitted here and use that in place of astdb or config.

The build-time dependencies usually match runtime but this is not a hard requirement.  In this case the build-time dependencies ensure build of modules that are usually required.  menuselect forces build of the default sorcery modules because without them the default runtime would fail.  Having to reconfigure modules.conf (if you have autoload=no) is minor compared to having to rebuild asterisk.  The module loader does not support conditional dependencies and it would be inappropriate to unconditionally force load of these modules at runtime.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15119
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I254dd33194ae38d2877b8021c57c2a5deb6bbcd2
Gerrit-Change-Number: 15119
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Corey Farrell <git at cfware.com>
Gerrit-Comment-Date: Tue, 03 Nov 2020 16:32:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201103/e1d1974d/attachment.html>