[Asterisk-code-review] pjproject: Upgrade bundled version to pjproject 2.10 (asterisk[16])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14413 )

Change subject: pjproject: Upgrade bundled version to pjproject 2.10
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14413/4/res/res_pjsip_outbound_publish.c 
File res/res_pjsip_outbound_publish.c:

https://gerrit.asterisk.org/c/asterisk/+/14413/4/res/res_pjsip_outbound_publish.c@1323 
PS4, Line 1323: 		if (!expires || !expires->ivalue || expires->ivalue == PJSIP_EXPIRES_NOT_SPECIFIED) {
> Is this change even needed?  We are adding a new value check that was not there before.
hrm I debated, but figured it couldn't hurt? But can remove it if you or others think so



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14413
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Iec8821c6cbbc08c369d0e3cd2f14e691b41d0c81
Gerrit-Change-Number: 14413
Gerrit-PatchSet: 4
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Thu, 21 May 2020 16:00:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Richard Mudgett <rmudgett at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200521/799ec64f/attachment.html>