[Asterisk-code-review] res_stir_shaken: Implemented signing of JSON payload. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14031 )

Change subject: res_stir_shaken: Implemented signing of JSON payload.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14031/1/res/res_stir_shaken.c 
File res/res_stir_shaken.c:

https://gerrit.asterisk.org/c/asterisk/+/14031/1/res/res_stir_shaken.c@340 
PS1, Line 340: 	json_str = ast_json_dump_string(json);
ast_json_dump_string will dump objects using insertion order in jansson 2.8+.  I'm not sure what older versions do might be undefined/hash order but that only matters if this gets backported to Asterisk 13.  You may want to create a way for main/json.c to dump strings using the jansson JSON_SORT_KEYS flag so the signature does not depend on object insertion order (though I don't see the signature verification so I'm not positive on this).



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14031
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I74fa41c0640ab2a64a1a80110155bd7062f13393
Gerrit-Change-Number: 14031
Gerrit-PatchSet: 1
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Corey Farrell <git at cfware.com>
Gerrit-Comment-Date: Mon, 30 Mar 2020 16:02:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200330/1ad751d7/attachment.html>