[Asterisk-code-review] func_aes: Avoid incorrect error message on load. (asterisk[17])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14010 )

Change subject: func_aes: Avoid incorrect error message on load.
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> > Patch Set 1:
> > 
> > Yes, you can flip a coin because both approaches to this have their reasons. With your approach, not AST_MODULE_INFO (runtime) but MODULEINFO (compile time) has to be changed from optional to required. I went for my approach because it is no functional change between Asterisk 13 LTS and Asterisk 16 LTS. With your approach, I have to change Asterisk 13 LTS as well. Again, both approaches have their reason. Somebody has to decide.
> 
> I would vote for fixing the MODULEINFO in all versions to ensure func_aes won't build without res_crypto.
> 
> I think we should also check for an error result from all calls to res_crypto functions, return an error from the dialplan functions if appropriate.  This would be especially useful in Asterisk 13 which cannot prevent func_aes from inappropriately loading but even for 16+ if the actual openssl functions return an error we should ensure the dialplan functions give an error.

Agreed!


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14010
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 17
Gerrit-Change-Id: I0b99b8468cbeb3b0eab23069cbd64062ef885ffc
Gerrit-Change-Number: 14010
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Corey Farrell <git at cfware.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 25 Mar 2020 15:04:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200325/d4083a44/attachment.html>