[Asterisk-code-review] codec_negotiation: Implement outgoing_call_offer_pref (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13945 )

Change subject: codec_negotiation: Implement outgoing_call_offer_pref
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.asterisk.org/c/asterisk/+/13945/4/res/res_pjsip_session/pjsip_session_caps.c 
File res/res_pjsip_session/pjsip_session_caps.c:

https://gerrit.asterisk.org/c/asterisk/+/13945/4/res/res_pjsip_session/pjsip_session_caps.c@32 
PS4, Line 32: struct ast_sip_session_caps {
            : 	struct ast_format_cap *call_offer_cap;
            : };
> Delete this (unused)

Durn.  I thought I did that.


https://gerrit.asterisk.org/c/asterisk/+/13945/4/res/res_pjsip_session/pjsip_session_caps.c@101 
PS4, Line 101: 
> just a suggestion, but looks like local_filtered is not used past this point, so could unref earlier here if you wanted.

Good point.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13945
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Id4ec0b4a906c2ae5885bf947f101c59059935437
Gerrit-Change-Number: 13945
Gerrit-PatchSet: 4
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 18 Mar 2020 17:32:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200318/805da752/attachment.html>