[Asterisk-code-review] codec_negotiation: Implement outgoing_call_offer_pref (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13945 )

Change subject: codec_negotiation: Implement outgoing_call_offer_pref
......................................................................


Patch Set 1:

(3 comments)

I know this is marked WIP (not sure if it will still be after this), but I figured I'd give this a look over anyhow.

https://gerrit.asterisk.org/c/asterisk/+/13945/1/include/asterisk/res_pjsip_session_caps.h 
File include/asterisk/res_pjsip_session_caps.h:

https://gerrit.asterisk.org/c/asterisk/+/13945/1/include/asterisk/res_pjsip_session_caps.h@24 
PS1, Line 24: struct ast_sip_session_caps;
This appears to no longer be used and can be removed?


https://gerrit.asterisk.org/c/asterisk/+/13945/1/res/res_pjsip_session/pjsip_session_caps.c 
File res/res_pjsip_session/pjsip_session_caps.c:

https://gerrit.asterisk.org/c/asterisk/+/13945/1/res/res_pjsip_session/pjsip_session_caps.c@35 
PS1, Line 35: struct ast_sip_session_caps {
            : 	struct ast_format_cap *call_offer_cap;
            : };
No longer used and can be removed?


https://gerrit.asterisk.org/c/asterisk/+/13945/1/res/res_pjsip_session/pjsip_session_caps.c@139 
PS1, Line 139: 		session->endpoint->preferred_codec_only) {
This needs to be moved out of this function. It only applies to incoming, and I think we want to make this and the new "incoming" option mutually exclusive (if one is set the other shouldn't be)



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13945
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Id4ec0b4a906c2ae5885bf947f101c59059935437
Gerrit-Change-Number: 13945
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 17 Mar 2020 23:28:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200317/d9947f83/attachment.html>