[Asterisk-code-review] res_pjsip_session: Fixed wrong session termination (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13806 )

Change subject: res_pjsip_session: Fixed wrong session termination
......................................................................


Patch Set 9: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/13806/9/res/res_pjsip_session.c 
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/c/asterisk/+/13806/9/res/res_pjsip_session.c@3888 
PS9, Line 3888: 						pjsip_inv_end_session(session->inv_session, ast_channel_hangupcause(session->channel), NULL, &tdata);
Why did you use ast_channel_hangupcause here? It returns the ISDN cause code, while this function takes a SIP response code. Since it's sending a BYE though it doesn't really matter so you should put a sane dummy value instead (like 503).



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13806
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifa864e0e125b1a7ed2f3abd4164187e1dddc56da
Gerrit-Change-Number: 13806
Gerrit-PatchSet: 9
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 09 Mar 2020 10:39:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200309/86c3e601/attachment.html>