[Asterisk-code-review] app_stream_echo: Fix state of added streams. (asterisk[17])

Joshua Colp asteriskteam at digium.com
Fri Jun 19 09:15:15 CDT 2020


Joshua Colp has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/14591 )

Change subject: app_stream_echo: Fix state of added streams.
......................................................................

app_stream_echo: Fix state of added streams.

When stream support was added to Asterisk the stream state
was used inconsistently, resulting in odd behavior. This
was then standardized to be the state of a stream from the
perspective of Asterisk.

This change updates the StreamEcho dialplan application
to use the correct state, send only, since we are only
sending to the endpoint and not expecting them to send us
multiple video streams.

ASTERISK-28954

Change-Id: I35bfd533ef1184ffe62586b22bbd253c82872a56
---
M apps/app_stream_echo.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Kevin Harwell: Looks good to me, but someone else must approve
  Benjamin Keith Ford: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Joshua Colp: Approved for Submit



diff --git a/apps/app_stream_echo.c b/apps/app_stream_echo.c
index 717ed1c..669f92e 100644
--- a/apps/app_stream_echo.c
+++ b/apps/app_stream_echo.c
@@ -274,7 +274,7 @@
 			 * cloning the same stream.
 			 */
 			ast_stream_set_state(stream, n == num ?
-			     AST_STREAM_STATE_SENDRECV : AST_STREAM_STATE_RECVONLY);
+			     AST_STREAM_STATE_SENDRECV : AST_STREAM_STATE_SENDONLY);
 		} while (--n);
 	}
 

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14591
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 17
Gerrit-Change-Id: I35bfd533ef1184ffe62586b22bbd253c82872a56
Gerrit-Change-Number: 14591
Gerrit-PatchSet: 2
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200619/63bfde4c/attachment-0001.html>


More information about the asterisk-code-review mailing list