[Asterisk-code-review] app_queue: Remove stale code in try_calling (asterisk[13])

Friendly Automation asteriskteam at digium.com
Wed Jun 17 08:32:15 CDT 2020


Friendly Automation has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/14561 )

Change subject: app_queue: Remove stale code in try_calling
......................................................................

app_queue: Remove stale code in try_calling

Because ring_entry() is not called, outgoing->chan is not touched here
either.

ASTERISK-28950
ASTERISK-28644

Change-Id: I564613715dfaf45af868251eb75a451f512af90f
---
M apps/app_queue.c
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Kevin Harwell: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Friendly Automation: Approved for Submit



diff --git a/apps/app_queue.c b/apps/app_queue.c
index 3a572ef..1580734 100644
--- a/apps/app_queue.c
+++ b/apps/app_queue.c
@@ -6649,9 +6649,6 @@
 			   hung up XXX */
 			tmp->q_next = outgoing;
 			outgoing = tmp;
-			/* If this line is up, don't try anybody else */
-			if (outgoing->chan && (ast_channel_state(outgoing->chan) == AST_STATE_UP))
-				break;
 		} else {
 			callattempt_free(tmp);
 		}

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14561
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I564613715dfaf45af868251eb75a451f512af90f
Gerrit-Change-Number: 14561
Gerrit-PatchSet: 2
Gerrit-Owner: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200617/f9890b83/attachment-0001.html>


More information about the asterisk-code-review mailing list