[Asterisk-code-review] res_stir_shaken: Add outbound INVITE support. (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14509 )

Change subject: res_stir_shaken: Add outbound INVITE support.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/c/asterisk/+/14509/1/res/res_pjsip_stir_shaken.c 
File res/res_pjsip_stir_shaken.c:

https://gerrit.asterisk.org/c/asterisk/+/14509/1/res/res_pjsip_stir_shaken.c@276 
PS1, Line 276: 	if (ast_strlen_zero(session->id.number.str)) {
I think this should check session->id.number.valid as well first


https://gerrit.asterisk.org/c/asterisk/+/14509/1/res/res_stir_shaken/certificate.c 
File res/res_stir_shaken/certificate.c:

https://gerrit.asterisk.org/c/asterisk/+/14509/1/res/res_stir_shaken/certificate.c@128 
PS1, Line 128: 	if (strlen(cert->attestation) == 0) {
ast_strlen_zero



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14509
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I1f84d6a5839cb2ed152ef4255b380cfc2de662b4
Gerrit-Change-Number: 14509
Gerrit-PatchSet: 1
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Fri, 12 Jun 2020 10:31:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200612/fe500406/attachment.html>