[Asterisk-code-review] res_fax: Don't start a gateway if either channel is hung up (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14460 )

Change subject: res_fax: Don't start a gateway if either channel is hung up
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14460/1/res/res_fax.c 
File res/res_fax.c:

https://gerrit.asterisk.org/c/asterisk/+/14460/1/res/res_fax.c@3447 
PS1, Line 3447: 
> Is there a reason that the ast_check_hangup function or a variant wasn't used?
Seems like it can be used here, and would even implicitly add a few more checks and logging.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14460
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I4e10e63b667bbb68c1c8623f977488f5d807897c
Gerrit-Change-Number: 14460
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Fri, 05 Jun 2020 18:33:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200605/983c539c/attachment.html>