[Asterisk-code-review] bridge_channel: Don't queue unmapped frames. (asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14503 )

Change subject: bridge_channel: Don't queue unmapped frames.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14503/2/main/bridge_channel.c 
File main/bridge_channel.c:

https://gerrit.asterisk.org/c/asterisk/+/14503/2/main/bridge_channel.c@1063 
PS2, Line 1063: 	dup = ast_frdup(fr);
              : 	if (!dup) {
              : 		return -1;
              : 	}
              : 
> Could move this down to just before the INSERT_TAIL as an additional optimization since we don't use […]
My concern was holding the lock while doing the frame duplication. It may be minor in the grand scheme of things.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14503
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I17189b9b1dec45fc7e4490e8081d444a25a00bda
Gerrit-Change-Number: 14503
Gerrit-PatchSet: 2
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Fri, 05 Jun 2020 14:20:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200605/2ee625c1/attachment.html>