[Asterisk-code-review] res_musiconhold.c: Prevent crash with realtime MoH (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14684 )

Change subject: res_musiconhold.c: Prevent crash with realtime MoH
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14684/2/res/res_musiconhold.c 
File res/res_musiconhold.c:

https://gerrit.asterisk.org/c/asterisk/+/14684/2/res/res_musiconhold.c@1755 
PS2, Line 1755: 	ao2_cleanup(class->files);
> All other accesses to the 'files' pointer are protected by the mohclass lock, so I want to say yes. […]
In a destructor cleaning up the pocket universe I'd be concerned if something else was using this, thus my query.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14684
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I479c5dcf88db670956e8cac177b5826c986b0217
Gerrit-Change-Number: 14684
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 28 Jul 2020 16:39:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean.bright at gmail.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200728/fd1f3669/attachment.html>