[Asterisk-code-review] ACN: Changes specific to the core (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14688 )

Change subject: ACN: Changes specific to the core
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/c/asterisk/+/14688/2/include/asterisk/channel.h 
File include/asterisk/channel.h:

https://gerrit.asterisk.org/c/asterisk/+/14688/2/include/asterisk/channel.h@1102 
PS2, Line 1102: 	struct ast_stream_topology *peer_topology;
I think this should be named answer_topology instead to better reflect what this is actually. The fact that it came from a peer is really none of the concern of the bridging code, it just knows it should use this topology for answering.


https://gerrit.asterisk.org/c/asterisk/+/14688/2/main/frame.c 
File main/frame.c:

https://gerrit.asterisk.org/c/asterisk/+/14688/2/main/frame.c@144 
PS2, Line 144: 				struct ast_stream_topology *topology = *((struct ast_stream_topology **)fr->data.ptr);
I'll let others chime in but it feels kludgey to use the data.ptr for this. The way you access the pointer hurts my head.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14688
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I0115d2ed68d6bae0f87e85abcf16c771bdaf992c
Gerrit-Change-Number: 14688
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 22 Jul 2020 09:49:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200722/fc9dd0fb/attachment.html>