[Asterisk-code-review] ACN: Advanced Codec Negotiation for chan_pjsip (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14637 )

Change subject: ACN: Advanced Codec Negotiation for chan_pjsip
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14637/1/channels/chan_pjsip.c 
File channels/chan_pjsip.c:

https://gerrit.asterisk.org/c/asterisk/+/14637/1/channels/chan_pjsip.c@3494 
PS1, Line 3494: 			ast_queue_control_data(session->channel, AST_CONTROL_ANSWER,
I don't think this is correct. Queueing data requires a contiguous allocation of memory to copy, while a topology is a reference counted object with many different allocations inside. I think that topology has to be a field within ast_frame_subclass as a union with format. Logic then has to be put into frame.c for duping and freeing, which manipulates the reference count as appropriate.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14637
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iad188ae997bdcb5c28e2eb12c6bb2b732538ad45
Gerrit-Change-Number: 14637
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 16 Jul 2020 12:08:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200716/87d636f1/attachment.html>