[Asterisk-code-review] app_record: Do not hang up if beep audio is missing (asterisk[17])

Joshua Colp asteriskteam at digium.com
Tue Jan 14 09:10:50 CST 2020


Joshua Colp has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/13606 )

Change subject: app_record: Do not hang up if beep audio is missing
......................................................................

app_record: Do not hang up if beep audio is missing

Additionally alter the warning to mention that it was "beep" which could
not be streamed to give admins a better clue about what the warning
means.

ASTERISK-28682

Change-Id: If5aed21226a173117ed17589f44826dd1ba6576e
---
M apps/app_record.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Kevin Harwell: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Joshua Colp: Approved for Submit



diff --git a/apps/app_record.c b/apps/app_record.c
index c4de981..93249e4 100644
--- a/apps/app_record.c
+++ b/apps/app_record.c
@@ -358,7 +358,8 @@
 		if (!res) {
 			res = ast_waitstream(chan, "");
 		} else {
-			ast_log(LOG_WARNING, "ast_streamfile failed on %s\n", ast_channel_name(chan));
+			ast_log(LOG_WARNING, "ast_streamfile(beep) failed on %s\n", ast_channel_name(chan));
+			res = 0;
 		}
 		ast_stopstream(chan);
 	}

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13606
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 17
Gerrit-Change-Id: If5aed21226a173117ed17589f44826dd1ba6576e
Gerrit-Change-Number: 13606
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200114/9514dbe0/attachment.html>


More information about the asterisk-code-review mailing list