[Asterisk-code-review] check_expr2: fix cross-compile/hardening issues (asterisk[master])

[Sebastian Kemper]

Sebastian Kemper has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13591 )

Change subject: check_expr2: fix cross-compile/hardening issues
......................................................................


Patch Set 2:

Hello Sean,

Thanks for the feedback. I added '-DYY_NO_INPUT' to the flags to resolve this warning:

ast_expr2f.c:1583:16: error: 'input' defined but not used [-Werror=unused-function]

TBH with '--enable-dev-mode' the build fails a bit earlier for me (astmm.c). When I disable fortify-source in OpenWrt it works fine initially (also for check_expr2), but still fails later at astobj2.c.

Anyway, your Gerrit build test passes now.

Kind regards,
Sean


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13591
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If435b7db9f9ad8266245bda51c81c220f9658915
Gerrit-Change-Number: 13591
Gerrit-PatchSet: 2
Gerrit-Owner: Sebastian Kemper <sebastian_ml at gmx.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Sun, 12 Jan 2020 18:47:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200112/5e5bad27/attachment.html>