[Asterisk-code-review] asymmetric_rtp_codec dialplan function (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13501 )

Change subject: asymmetric_rtp_codec dialplan function
......................................................................


Patch Set 1: Code-Review-1

I think this is setting a poor precedent for how to do this type of thing. There's many different options that people could want to change, and having a dialplan function for each doesn't really seem like a great experience.

Instead what if there was a dialplan function that accepted any options you could set in a .conf for an endpoint, and when invoked would then set it? This could be done by keeping track of whether the endpoint on the session is a copy or not. If it's not a copy then ast_sorcery_copy could be used to create one. After which ast_sorcery_objectset_apply could be used to apply the option and value. A pre-dial handler could be used to set the various options people may want.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13501
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I600d5ac1c6c2b47a7a0da6425aea559f1aa61c7c
Gerrit-Change-Number: 13501
Gerrit-PatchSet: 1
Gerrit-Owner: Salah Ahmed <txrubel at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 02 Jan 2020 14:16:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200102/345eb58f/attachment.html>