[Asterisk-code-review] res_pjsip_session: Fixed wrong session termination (asterisk[master])

[sungtae kim]

sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13806 )

Change subject: res_pjsip_session: Fixed wrong session termination
......................................................................


Patch Set 7:

(2 comments)

Thanks Kevin,

I've replied it. Could you please take a look again? Thanks. 😊

https://gerrit.asterisk.org/c/asterisk/+/13806/6//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/13806/6//COMMIT_MSG@18 
PS6, Line 18: 
> This needs to include the Asterisk issue id.
Done


https://gerrit.asterisk.org/c/asterisk/+/13806/6/res/res_pjsip_session.c 
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/c/asterisk/+/13806/6/res/res_pjsip_session.c@3884 
PS6, Line 3884: 						ast_debug(1, "Endpoint '%s(%s)': Ending session due to 200 OK with incomplete SDP negotiation.  %s\n",
              : 							ast_sorcery_object_get_id(session->endpoint),
              : 							session->channel ? ast_channel_name(session->channel) : "",
              : 							pjsip_rx_data_get_info(e->body.tsx_state.src.rdata));
              : 						delay_request(session, NULL, NULL, NULL, 0, DELAYED_METHOD_BYE, NULL);
              : 						return;
> Are re-invites affected by this? If it can get here after a re-ininvite then we shouldn't be termina […]
No, this is happening while the Asterisk(PJPROJECT) sending a ACK. And the Re-Invite is not triggered it yet. Plus actually, in this case, the re-invite shouldn't triggered. Because the session is already in the terminated progress.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13806
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifa864e0e125b1a7ed2f3abd4164187e1dddc56da
Gerrit-Change-Number: 13806
Gerrit-PatchSet: 7
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Fri, 28 Feb 2020 14:31:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200228/ef260064/attachment.html>