[Asterisk-code-review] res_pjsip_session: Fixed wrong session termination (asterisk[master])

[sungtae kim]

sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13806 )

Change subject: res_pjsip_session: Fixed wrong session termination
......................................................................


Patch Set 6:

(1 comment)

> Patch Set 5: Code-Review-1
> 
> (1 comment)

You're right. Updated patch. Could you please review this? Thanks.

https://gerrit.asterisk.org/c/asterisk/+/13806/5/res/res_pjsip_session.c 
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/c/asterisk/+/13806/5/res/res_pjsip_session.c@3883 
PS5, Line 3883: 						if (pjsip_inv_end_session(inv, 500, NULL, &tdata) == PJ_SUCCESS
> If the BYE has already been sent what does pjsip_inv_end_session here do exactly to resolve the prob […]
Indeed wrong explanation. We need to send the BYE here, because PJPROJECT didn't send the BYE yet.

And we've set the proper cause code already in the session_inv_on_media_update(), we don't need to update the cause code here too.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13806
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifa864e0e125b1a7ed2f3abd4164187e1dddc56da
Gerrit-Change-Number: 13806
Gerrit-PatchSet: 6
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 27 Feb 2020 16:52:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200227/98736bfb/attachment.html>