[Asterisk-code-review] A non negotiated rtp frame causes call disconnection when there is a ... (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13846 )

Change subject: A non negotiated rtp frame causes call disconnection when there is a SSRC change
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

I don't think this is the correct fix for this and to be able to determine the right one we're going to need more information about what exactly is happening. What control frame is being returned? What soft hangup flag is being set?

https://gerrit.asterisk.org/c/asterisk/+/13846/1/res/res_rtp_asterisk.c 
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/c/asterisk/+/13846/1/res/res_rtp_asterisk.c@5969 
PS1, Line 5969: 	ast = ast_channel_get_by_name(ast_rtp_instance_get_channel_id(instance));
This is *extremely* expensive to have happen on every frame and essentially makes this block every other thread which may be reading in RTP while doing so.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13846
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I6d854cc523f343e299a615636fc65bdbd5f809ec
Gerrit-Change-Number: 13846
Gerrit-PatchSet: 1
Gerrit-Owner: Paulo Vicentini <paulo.vicentini at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 26 Feb 2020 01:07:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200225/d59b2344/attachment.html>