[Asterisk-code-review] res_pjsip_sdp_rtp: implement full state machin for MOH_PASSTHROUGH (testsuite[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/13803 )

Change subject: res_pjsip_sdp_rtp: implement full state machin for MOH_PASSTHROUGH
......................................................................


Patch Set 6: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/c/testsuite/+/13803/6//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/c/testsuite/+/13803/6//COMMIT_MSG@7 
PS6, Line 7: res_pjsip_sdp_rtp: implement full state machin for MOH_PASSTHROUGH
machine


https://gerrit.asterisk.org/c/testsuite/+/13803/6/tests/channels/pjsip/moh_passthru_inactive/test-config.yaml 
File tests/channels/pjsip/moh_passthru_inactive/test-config.yaml:

https://gerrit.asterisk.org/c/testsuite/+/13803/6/tests/channels/pjsip/moh_passthru_inactive/test-config.yaml@2 
PS6, Line 2:     summary: 'Test that if Asterisk sets stream to inactive'
This summary doesn't quite make sense


https://gerrit.asterisk.org/c/testsuite/+/13803/6/tests/channels/pjsip/moh_passthru_inactive/test-config.yaml@4 
PS6, Line 4:          'Asterisk if both ends have request to be on hold, then the sdp shoul 
should


https://gerrit.asterisk.org/c/testsuite/+/13803/6/tests/channels/pjsip/moh_passthru_inactive/test-config.yaml@5 
PS6, Line 5:           say inactive instead or receiveonly'
recvonly



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/13803
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 13
Gerrit-Change-Id: I8b22fe78f5cc02c2b0b888d51df296c4509b1563
Gerrit-Change-Number: 13803
Gerrit-PatchSet: 6
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 25 Feb 2020 17:16:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200225/01afa4f4/attachment.html>