[Asterisk-code-review] res_pjsip_session: Added channel hangup check (asterisk[master])

[sungtae kim]

sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13806 )

Change subject: res_pjsip_session: Added channel hangup check
......................................................................


Patch Set 2:

> Patch Set 2:
> 
> > Patch Set 2:
> > 
> > (1 comment)
> > 
> > Hi Joshua,
> > 
> > Thank you for your replying. I have added comment to here. Could you please check it?
> > 
> > Thanks.
> 
> Our threading model should have things executed in a serialized fashion so that two threads aren't operating on the session in PJSIP at the same time, so that there can't be a race condition. If this isn't true then we need to identify where and why.

Agree, this is not about race-condition. It's about the bad memory access. And I believe this is pjsip's responsibility.

I've submitted small patch to the pjsip community. Not sure they accept that or not, but once they've accepted it I will close this.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13806
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifa864e0e125b1a7ed2f3abd4164187e1dddc56da
Gerrit-Change-Number: 13806
Gerrit-PatchSet: 2
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 19 Feb 2020 14:47:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200219/8d8d62ce/attachment.html>