[Asterisk-code-review] RTP/ICE: Send on first valid pair. (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13731 )

Change subject: RTP/ICE: Send on first valid pair.
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/13731/5/res/res_rtp_asterisk.c 
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/c/asterisk/+/13731/5/res/res_rtp_asterisk.c@2169 
PS5, Line 2169: 	if (status == PJ_SUCCESS) {
              : 		struct ast_sockaddr remote_address;
              : 
              : 		ast_sockaddr_setnull(&remote_address);
              : 		update_address_with_ice_candidate(ice, AST_RTP_ICE_COMPONENT_RTP, &remote_address);
              : 		if (!ast_sockaddr_isnull(&remote_address)) {
              : 			/* Symmetric RTP must be disabled for the remote address to not get overwritten */
              : 			ast_rtp_instance_set_prop(instance, AST_RTP_PROPERTY_NAT, 0);
              : 
              : 			ast_rtp_instance_set_remote_address(instance, &remote_address);
              : 		}
              : 
              : 		if (rtp->rtcp) {
              : 			update_address_with_ice_candidate(ice, AST_RTP_ICE_COMPONENT_RTCP, &rtp->rtcp->them);
              : 		}
              : 	}
> I was looking at this as well. […]
Good point. I think ice_media_started should be reset to 0 in ice_reset_session since that is resetting the negotiation, which will allow renegotiation to work as expected.

As well it does make sense here to update the address information even if ice_media_started since the chosen candidate may have changed.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13731
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Ia7b68c34f06d2a1d91c5ed51627b66fd0363d867
Gerrit-Change-Number: 13731
Gerrit-PatchSet: 5
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 17 Feb 2020 17:05:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Comment-In-Reply-To: Benjamin Keith Ford <bford at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200217/5867c334/attachment.html>