[Asterisk-code-review] app_mixmonitor: Set MIXMONITOR_FILENAME to correct value when wav49 i... (asterisk[13])

[Sean Bright]

Hello George Joseph, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/13808

to look at the new patch set (#3).

Change subject: app_mixmonitor: Set MIXMONITOR_FILENAME to correct value when wav49 is used
......................................................................

app_mixmonitor: Set MIXMONITOR_FILENAME to correct value when wav49 is used

When opening a file for writing, Asterisk silently converts filenames
ending with 'wav49' to 'WAV.' We aren't taking that in to account when
setting the MIXMONITOR_FILENAME variable in MixMonitor.

* If the user wants to write to a wav49 file, make sure that it is
  reflected properly in MIXMONITOR_FILENAME.

* Add a note to the documentation describing this behavior.

* Add a note in main/file.c indicating that app_mixmonitor needs to be
  changed if the logic in build_filename was changed.

ASTERISK-24798 #close
Reported by: xrobau

Change-Id: I384691ce624eb55c80a125b9ca206d2d691c574c
---
M apps/app_mixmonitor.c
A doc/CHANGES-staging/app_mixmonitor_wav49.txt
M main/file.c
3 files changed, 36 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/08/13808/3
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13808
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I384691ce624eb55c80a125b9ca206d2d691c574c
Gerrit-Change-Number: 13808
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Michael L. Young <elgueromexicano at gmail.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200217/cbc6adaa/attachment.html>