[Asterisk-code-review] bridging: Add better support for adding/removing streams. (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13784 )

Change subject: bridging: Add better support for adding/removing streams.
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.asterisk.org/c/asterisk/+/13784/3/bridges/bridge_softmix.c 
File bridges/bridge_softmix.c:

https://gerrit.asterisk.org/c/asterisk/+/13784/3/bridges/bridge_softmix.c@2276 
PS3, Line 2276: !strncmp(ast_stream_get_name(old_stream), SOFTBRIDGE_VIDEO_DEST_PREFIX,
              : 				SOFTBRIDGE_VIDEO_DEST_LEN)
> Do you need to check the new stream as well?
It's not possible for the stream name to change like that. They will always be in sync, unless the stream is removed on the local or remote side in which case the stream name wouldn't be a destination stream now.


https://gerrit.asterisk.org/c/asterisk/+/13784/3/res/res_pjsip_session.c 
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/c/asterisk/+/13784/3/res/res_pjsip_session.c@1070 
PS3, Line 1070: pjmedia_sdp_neg_was_answer_remote(session->inv_session->neg) == PJ_FALSE
> If this is checking for a remote change in topology, would it need to evaluate to PJ_TRUE instead? O […]
It's checking who initiated it. If they send a reinvite then we are the answer. If we send a reinvite then they are the answer.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13784
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I93f41fb41b85646bef71408111c17ccea30cb0c5
Gerrit-Change-Number: 13784
Gerrit-PatchSet: 3
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Comment-Date: Fri, 14 Feb 2020 18:47:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Keith Ford <bford at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200214/4acf9899/attachment.html>