[Asterisk-code-review] bridging: Add better support for adding/removing streams. (asterisk[16])

[Benjamin Keith Ford]

Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13738 )

Change subject: bridging: Add better support for adding/removing streams.
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

Some initial findings, will be taking a more in-depth look again later.

https://gerrit.asterisk.org/c/asterisk/+/13738/2/bridges/bridge_softmix.c 
File bridges/bridge_softmix.c:

https://gerrit.asterisk.org/c/asterisk/+/13738/2/bridges/bridge_softmix.c@2354 
PS2, Line 2354:                 if (append_all_streams(sc->topology, added_streams)) {
              :                         goto cleanup;
              :                 }
Tab spacing


https://gerrit.asterisk.org/c/asterisk/+/13738/2/bridges/bridge_softmix.c@2370 
PS2, Line 2370:                 ast_channel_request_stream_topology_change(participant->chan, sc->topology, NULL);
              :         }
Tab spacing



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13738
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I93f41fb41b85646bef71408111c17ccea30cb0c5
Gerrit-Change-Number: 13738
Gerrit-PatchSet: 2
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Comment-Date: Thu, 13 Feb 2020 17:32:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200213/1325eac5/attachment.html>