[Asterisk-code-review] app_chanspy: Spyee information missing in ChanSpyStop AMI Event (asterisk[16])

Sean Bright asteriskteam at digium.com
Fri Dec 11 13:55:25 CST 2020


Attention is currently required from: Hendrik Wedhorn, Sean Bright.
Sean Bright has uploaded a new patch set (#5) to the change originally created by Hendrik Wedhorn. ( https://gerrit.asterisk.org/c/asterisk/+/14889 )

Change subject: app_chanspy: Spyee information missing in ChanSpyStop AMI Event
......................................................................

app_chanspy: Spyee information missing in ChanSpyStop AMI Event

The documentation in the wiki says there should be spyee-channel
information elements in the ChanSpyStop AMI event.

    https://wiki.asterisk.org/wiki/x/Xc5uAg

However, this is not the case in Asterisk <= 16.10.0 Version. We're
using these Spyee* arguments since Asterisk 11.x, so these arguments
vanished in Asterisk 12 or higher.

For maximum compatibility, we still send the ChanSpyStop event even if
we are not able to find any 'Spyee' information.

ASTERISK-28883 #close

Change-Id: I81ce397a3fd614c094d043ffe5b1b1d76188835f
---
M apps/app_chanspy.c
M main/manager_channels.c
M res/res_stasis_snoop.c
3 files changed, 25 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/89/14889/5
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14889
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I81ce397a3fd614c094d043ffe5b1b1d76188835f
Gerrit-Change-Number: 14889
Gerrit-PatchSet: 5
Gerrit-Owner: Hendrik Wedhorn <hwedhorn at addix.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Sean Bright <sean.bright at gmail.com>
Gerrit-Attention: Hendrik Wedhorn <hwedhorn at addix.net>
Gerrit-Attention: Sean Bright <sean.bright at gmail.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201211/3add4abb/attachment.html>


More information about the asterisk-code-review mailing list