[Asterisk-code-review] logger.c: Automatically add a newline to formats that don't have one (asterisk[16])

George Joseph asteriskteam at digium.com
Fri Dec 11 07:29:41 CST 2020


Hello Sean Bright, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/15211

to look at the new patch set (#2).

Change subject: logger.c: Automatically add a newline to formats that don't have one
......................................................................

logger.c: Automatically add a newline to formats that don't have one

Scope tracing allows you to not specify a format string or
variable, in which case it just prints the indent, file,
function, and line number.  The trace output automatically
adds a newline to the end in this case.  If you also have
debugging turned on for the module, a debug message is
also printed but the standard log functionality which
prints it doesn't add the newline so you have messages
that don't break correctly.

 * format_log_message_ap(), which is the common log
   message formatter for all channels, now adds a
   newline to the end of format strings that don't
   already have a newline.

ASTERISK-29209
Reported by: Alexander Traud

Change-Id: I994a7df27f88df343b7d19f3e81a4b562d9d41da
---
M main/logger.c
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/11/15211/2
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15211
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I994a7df27f88df343b7d19f3e81a4b562d9d41da
Gerrit-Change-Number: 15211
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201211/2fedbb14/attachment.html>


More information about the asterisk-code-review mailing list