[Asterisk-code-review] samples: Fix keep_alive_interval default in pjsip.conf. (asterisk[17])

[Kevin Harwell]

Kevin Harwell has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/14825 )

Change subject: samples: Fix keep_alive_interval default in pjsip.conf.
......................................................................

samples: Fix keep_alive_interval default in pjsip.conf.

Since ASTERISK_27978 the default is not off but 90 seconds. That change
happened because ASTERISK_27347 disabled the keep-alives in the bundled
PJProject and Asterisk should behave the same as before.

Change-Id: Ie63dc558ade6a5a2b969c30a4bd492d63730dc46
---
M configs/samples/pjsip.conf.sample
1 file changed, 6 insertions(+), 4 deletions(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  Kevin Harwell: Looks good to me, approved; Approved for Submit
  George Joseph: Looks good to me, but someone else must approve



diff --git a/configs/samples/pjsip.conf.sample b/configs/samples/pjsip.conf.sample
index a88dd5c..ce5eb74 100644
--- a/configs/samples/pjsip.conf.sample
+++ b/configs/samples/pjsip.conf.sample
@@ -994,7 +994,8 @@
                         ; refreshing.
                         ; (default: "no")
 ;type=  ; Must be of type aor (default: "")
-;qualify_frequency=0    ; Interval at which to qualify an AoR (default: "0")
+;qualify_frequency=0    ; Interval at which to qualify an AoR via OPTIONS requests.
+                        ; (default: "0")
 ;qualify_timeout=3.0      ; Qualify timeout in fractional seconds (default: "3.0")
 ;authenticate_qualify=no        ; Authenticates a qualify request if needed
                                 ; (default: "no")
@@ -1066,9 +1067,10 @@
                                                         ; int")
 ;debug=no ; Enable/Disable SIP debug logging.  Valid options include yes|no
           ; or a host address (default: "no")
-;keep_alive_interval=20 ; The interval (in seconds) at which to send keepalive
-                        ; messages on all active connection-oriented transports
-                        ; (default: "0")
+;keep_alive_interval=90 ; The interval (in seconds) at which to send (double CRLF)
+                        ; keep-alives on all active connection-oriented transports;
+                        ; for connection-less like UDP see qualify_frequency.
+                        ; (default: "90")
 ;contact_expiration_check_interval=30
                         ; The interval (in seconds) to check for expired contacts.
 ;disable_multi_domain=no

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14825
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 17
Gerrit-Change-Id: Ie63dc558ade6a5a2b969c30a4bd492d63730dc46
Gerrit-Change-Number: 14825
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200828/78b9165b/attachment.html>