[Asterisk-code-review] logger.c: Added a new log formatter called "debug" (asterisk[16])

Kevin Harwell asteriskteam at digium.com
Tue Aug 25 09:54:25 CDT 2020


Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14776 )

Change subject: logger.c: Added a new log formatter called "debug"
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14776/4/configs/samples/logger.conf.sample 
File configs/samples/logger.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/14776/4/configs/samples/logger.conf.sample@112 
PS4, Line 112: ;   - [debug]   - The debug formatter, this outputs log messages using a
I feel like calling this something besides "debug" would be better since debug is already being used elsewhere in the logger. Something like "extras", "dev", "line", something else?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14776
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I4fdfe4089f66ce2f9cb29f3005522090dbb5243d
Gerrit-Change-Number: 14776
Gerrit-PatchSet: 4
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 25 Aug 2020 14:54:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200825/69b013c2/attachment.html>


More information about the asterisk-code-review mailing list