[Asterisk-code-review] app_followme: Allow disabling FollowMe prompt (asterisk[13])

[Dennis]

Dennis has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14696 )

Change subject: app_followme: Allow disabling FollowMe prompt
......................................................................


Patch Set 2:

(3 comments)

> Patch Set 2: Code-Review-2
> 
> This review can't be cleanly cherry-picked to the other branches.  You'll need to cherry-pick to 16 locally and figure out the conflicts.

I'm a little confused. You ask to cherry-pick manually but this was already done for 16, 18 and master branches? I also noticed those builds are unstable but I'm not sure what that means... Jenkins shows two failed pjsip tests and one failed AMI connection. I'm not sure how those are related to a chan_sip change? What should I do?

https://gerrit.asterisk.org/c/asterisk/+/14696/1/apps/app_followme.c 
File apps/app_followme.c:

https://gerrit.asterisk.org/c/asterisk/+/14696/1/apps/app_followme.c@965 
PS1, Line 965: 				// if no callee prompt enabled
> C++ style comments are not allowed. Please convert to C-style, e.g. […]
Ack


https://gerrit.asterisk.org/c/asterisk/+/14696/1/apps/app_followme.c@970 
PS1, Line 970: 				) { // make sure to perform all actions as if prompt is enabled
> Change to C-style comment
Ack


https://gerrit.asterisk.org/c/asterisk/+/14696/1/apps/app_followme.c@973 
PS1, Line 973: 					tmpuser->yn[tmpuser->ynidx++] = 1; // force 1???
> Change to C-style comment. […]
Ack



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14696
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Ic15a2bac4f16d0fce7a1b5e7b375f9bafee37aa4
Gerrit-Change-Number: 14696
Gerrit-PatchSet: 2
Gerrit-Owner: Dennis <dennis.buteyn at xorcom.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 19 Aug 2020 10:15:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200819/3ffb10fa/attachment.html>