[Asterisk-code-review] chan_mobile: Add smoother to make SIP/RTP endpoints happy. (asterisk[16])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14265 )

Change subject: chan_mobile: Add smoother to make SIP/RTP endpoints happy.
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

Once the debug message issue is corrected, you're good to cherry-pick this change to the 13, 17 and master branches.

https://gerrit.asterisk.org/c/asterisk/+/14265/3/addons/chan_mobile.c 
File addons/chan_mobile.c:

https://gerrit.asterisk.org/c/asterisk/+/14265/3/addons/chan_mobile.c@994 
PS3, Line 994: 	ast_log(LOG_ERROR, "Calling %s on %s\n", dest, ast_channel_name(ast));
I'm guessing this was changed to an ERROR for debugging purposes.  If so, it should be changed back to debug.  If not, the error message should be more meaningful.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14265
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ic5f9e2f35868ae59cc9356afbd1388b779a1267f
Gerrit-Change-Number: 14265
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Turczak <peter at turczak.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 27 Apr 2020 13:21:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200427/9584651c/attachment.html>