[Asterisk-code-review] stream: Enforce formats immutability and ensure formats exist. (asterisk[16])

[Joshua Colp]

Hello George Joseph, Kevin Harwell, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/14276

to look at the new patch set (#2).

Change subject: stream: Enforce formats immutability and ensure formats exist.
......................................................................

stream: Enforce formats immutability and ensure formats exist.

Some places in Asterisk did not treat the formats on a stream
as immutable when they are.

The ast_stream_get_formats function is now const to enforce this
and parts of Asterisk have been updated to take this into account.
Some violations of this were also fixed along the way.

An additional minor tweak is that streams are now allocated with
an empty format capabilities structure removing the need in various
places to check that one is present on the stream.

ASTERISK-28846

Change-Id: I32f29715330db4ff48edd6f1f359090458a9bfbe
---
M bridges/bridge_native_rtp.c
M bridges/bridge_simple.c
M bridges/bridge_softmix.c
M channels/chan_pjsip.c
M channels/pjsip/dialplan_functions.c
A doc/UPGRADE-staging/stream_immutable_formats.txt
M include/asterisk/stream.h
M main/stream.c
M res/res_pjsip_session.c
9 files changed, 59 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/76/14276/2
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14276
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I32f29715330db4ff48edd6f1f359090458a9bfbe
Gerrit-Change-Number: 14276
Gerrit-PatchSet: 2
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200422/7f1a3f5c/attachment.html>