[Asterisk-code-review] fax: Fix crashes in PJSIP re-negotiation scenarios. (asterisk[16])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14274 )

Change subject: fax: Fix crashes in PJSIP re-negotiation scenarios.
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/c/asterisk/+/14274/1/res/res_pjsip_session.c 
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/c/asterisk/+/14274/1/res/res_pjsip_session.c@1733 
PS1, Line 1733: ast_format_cap_get_compatible(ast_stream_get_formats(stream), session->endpoint->media.codecs, joint_cap);
Shouldn't ast_stream_get_formats need to be checked here too?


https://gerrit.asterisk.org/c/asterisk/+/14274/1/res/res_pjsip_session.c@1756 
PS1, Line 1756: joint_cap = ao2_bump(ast_stream_get_formats(existing_stream));
and here too?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14274
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I8ed5924b53be9fe06a385c58817e5584b0f25cc2
Gerrit-Change-Number: 14274
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-CC: Friendly Automation
Gerrit-Comment-Date: Mon, 20 Apr 2020 15:43:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200420/acff20ea/attachment.html>