[Asterisk-code-review] func_volume: Accept decimal number as argument (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14089 )

Change subject: func_volume: Accept decimal number as argument
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/c/asterisk/+/14089/1/include/asterisk/utils.h 
File include/asterisk/utils.h:

https://gerrit.asterisk.org/c/asterisk/+/14089/1/include/asterisk/utils.h@388 
PS1, Line 388: 		*input = (short) res;
Should this using rounding vs truncating in an attempt to be more precise?


https://gerrit.asterisk.org/c/asterisk/+/14089/1/include/asterisk/utils.h@404 
PS1, Line 404: 		*input = (short) res;
Same for this. Rounding vs truncating?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14089
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I5b42b890ec4e1f6b0b3400cb44ff16522b021c8c
Gerrit-Change-Number: 14089
Gerrit-PatchSet: 1
Gerrit-Owner: Jean Aunis - Prescom <jean.aunis at prescom.fr>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 08 Apr 2020 15:41:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200408/f7c363e3/attachment.html>