[Asterisk-code-review] Revert "res_config_odbc: Preserve empty strings returned by the datab... (asterisk[16])

[Joshua Colp]

Joshua Colp has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/14124 )

Change subject: Revert "res_config_odbc: Preserve empty strings returned by the database"
......................................................................

Revert "res_config_odbc: Preserve empty strings returned by the database"

This reverts commit a3a2fbaec685d931d56f669f2d4171220e9977ac.

Reason for revert: There is a lot of code that relies on the broken
behavior that this fixes.

Change-Id: I410c395a0168acbdaf89e616e3cb5e1312d190cb
---
M res/res_config_odbc.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve; Approved for Submit
  Kevin Harwell: Looks good to me, approved
  George Joseph: Looks good to me, but someone else must approve



diff --git a/res/res_config_odbc.c b/res/res_config_odbc.c
index 45bb214..fd0078f 100644
--- a/res/res_config_odbc.c
+++ b/res/res_config_odbc.c
@@ -303,7 +303,7 @@
 		} else {
 			while (stringp) {
 				chunk = strsep(&stringp, ";");
-				if (!strcmp(chunk, " ") || !ast_strlen_zero(ast_strip(chunk))) {
+				if (!ast_strlen_zero(ast_strip(chunk))) {
 					if (strchr(chunk, '^')) {
 						decode_chunk(chunk);
 					}

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14124
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I410c395a0168acbdaf89e616e3cb5e1312d190cb
Gerrit-Change-Number: 14124
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200408/a0af8968/attachment-0001.html>