[Asterisk-code-review] res_pjsip_mwi: Remove inappropriate topic unreference. (...asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/12903 )

Change subject: res_pjsip_mwi: Remove inappropriate topic unreference.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/12903/1/main/stasis_cache.c 
File main/stasis_cache.c:

https://gerrit.asterisk.org/#/c/12903/1/main/stasis_cache.c@873 
PS1, Line 873: 				ao2_cleanup(cache_remove(caching_topic->cache->entries, sub, stasis_message_eid(message)));
I'm not sure this is correct. 'cache_remove' does not bump the returned stasis_message reference, which it obtains from the cached_entry.

By removing the reference here it seems like when cached_entry's destructor eventually gets called then it too would attempt to de-reference causing too many de-references on the object.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/12903
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I51101bf7d07b8dc8ce8fc46b6cb31fbbd213fbc7
Gerrit-Change-Number: 12903
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 23 Sep 2019 16:59:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190923/fc4371ce/attachment-0001.html>