[Asterisk-code-review] core: Add H.265/HEVC passthrough support (...asterisk[16])

[Florian Floimair]

Florian Floimair has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/12774 )

Change subject: core: Add H.265/HEVC passthrough support
......................................................................


Patch Set 3:

(1 comment)

Please have a look at the following line.
I think it should look equal to h264 line.

So most probably:

(channel->session->endpoint->media.webrtc &&
 ast_format_cap_iscompatible_format(ast_channel_nativeformats(ast), ast_format_h265) != AST_FORMAT_CMP_NOT_EQUAL))

instead of just the format comparison (like with VP8 and VP9)

https://gerrit.asterisk.org/#/c/12774/3/channels/chan_pjsip.c 
File channels/chan_pjsip.c:

https://gerrit.asterisk.org/#/c/12774/3/channels/chan_pjsip.c@1657 
PS3, Line 1657: 					ast_format_cap_iscompatible_format(ast_channel_nativeformats(ast), ast_format_h265) != AST_FORMAT_CMP_NOT_EQUAL ||
After further looking into this I think this is wrong and should be in parentheses together with check on webrtc (like h264 line below). Can you please confirm?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/12774
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I26d262cc4110b4f7e99348a3ddc53bad0d2cd1f2
Gerrit-Change-Number: 12774
Gerrit-PatchSet: 3
Gerrit-Owner: Florian Floimair <f.floimair at commend.com>
Gerrit-Reviewer: Florian Floimair <f.floimair at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 17 Sep 2019 12:11:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190917/6ef47c83/attachment.html>