[Asterisk-code-review] contrib/scripts: Make spandspflow2pcap.py Python 2.7+/3.3+ compatible (...asterisk[master])

Walter Doekes asteriskteam at digium.com
Thu Sep 5 02:46:01 CDT 2019


Walter Doekes has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11602 )

Change subject: contrib/scripts: Make spandspflow2pcap.py Python 2.7+/3.3+ compatible
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/11602/1//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/#/c/11602/1//COMMIT_MSG@7 
PS1, Line 7: contrib/scripts: Make spandspflow2pcap.py Python 2.7+/3.3+ compatible
> Just a suggestion, but it appears these changes include more than just compatibility updates, so mor […]
Ack.


Thanks for the review and the suggestion and the merge!

(And no, the "other" changes were so small that they didn't warrant any additional writeup other than than the denomination refactoring (not overwriting existing files, defaulting to 0600 mode, better inline docs).)



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11602
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ica182a891743017ff3cda16de3d95335fffd9a91
Gerrit-Change-Number: 11602
Gerrit-PatchSet: 1
Gerrit-Owner: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-Comment-Date: Thu, 05 Sep 2019 07:46:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190905/e72b8d03/attachment-0001.html>


More information about the asterisk-code-review mailing list