[Asterisk-code-review] various files - fix some alerts raised by lgtm code analysis (...asterisk[13])

[Kevin Harwell]

Hello Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/13102

to look at the new patch set (#3).

Change subject: various files - fix some alerts raised by lgtm code analysis
......................................................................

various files - fix some alerts raised by lgtm code analysis

This patch fixes several issues reported by the lgtm code analysis tool:

https://lgtm.com/projects/g/asterisk/asterisk

Not all reported issues were addressed in this patch. This patch mostly fixes
confirmed reported errors, potential problematic code points, and a few other
"low hanging" warnings or recommendations found in core supported modules.
These include, but are not limited to the following:

* innapropriate stack allocation in loops
* buffer overflows
* variable declaration "hiding" another variable declaration
* comparisons results that are always the same
* ambiguously signed bit-field members
* missing header guards

Change-Id: Id4a881686605d26c94ab5409bc70fcc21efacc25
---
M apps/app_cdr.c
M apps/app_dictate.c
M apps/app_followme.c
M apps/app_minivm.c
M apps/app_playback.c
M apps/app_readexten.c
M apps/app_voicemail.c
M channels/chan_dahdi.c
M channels/chan_dahdi.h
M channels/chan_motif.c
M codecs/ex_alaw.h
M codecs/ex_g722.h
M codecs/ex_ulaw.h
M formats/format_g726.c
M formats/msgsm.h
M include/asterisk/ari.h
M include/asterisk/calendar.h
M include/asterisk/channel_internal.h
M include/asterisk/config_options.h
M include/asterisk/max_forwards.h
M include/asterisk/mixmonitor.h
M include/asterisk/parking.h
M include/asterisk/res_pjsip_presence_xml.h
M include/asterisk/slin.h
M main/app.c
M main/asterisk.c
M main/event.c
M main/file.c
M main/indications.c
M main/manager.c
M main/pbx_variables.c
M main/stasis.c
M main/stasis_cache.c
M res/ari/config.c
M res/parking/parking_bridge_features.c
M res/parking/res_parking.h
M res/res_config_curl.c
M res/res_phoneprov.c
M res/res_pjsip/config_system.c
M res/res_pjsip/config_transport.c
M res/res_pjsip_endpoint_identifier_ip.c
M res/res_pjsip_registrar.c
M res/res_rtp_asterisk.c
M res/stasis/command.c
M res/stasis/control.c
45 files changed, 306 insertions(+), 195 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/02/13102/3
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13102
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Id4a881686605d26c94ab5409bc70fcc21efacc25
Gerrit-Change-Number: 13102
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Sean Bright <sean.bright at gmail.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191024/425cdb2a/attachment.html>