[Asterisk-code-review] res_pjsip_messaging: Rewrite To: to normalize recipient (...asterisk[13])

[Brian J. Murrell]

Brian J. Murrell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13065 )

Change subject: res_pjsip_messaging:  Rewrite To: to normalize recipient
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/13065/1/res/res_pjsip_messaging.c 
File res/res_pjsip_messaging.c:

https://gerrit.asterisk.org/#/c/13065/1/res/res_pjsip_messaging.c@46 
PS1, Line 46: #include "asterisk/paths.h"
> I don't think having a warning here is needed. […]
I assume this comment is actually in reference to line #240-241.  That's a fair enough point.

I will remove the logging.  Or would it still be useful to keep and set to LOG_DEBUG perhaps?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13065
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Iab8d472081d22ed80a3abf3b34833d898306ac8e
Gerrit-Change-Number: 13065
Gerrit-PatchSet: 1
Gerrit-Owner: Brian J. Murrell <brian at interlinx.bc.ca>
Gerrit-Reviewer: Brian J. Murrell <brian at interlinx.bc.ca>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Fri, 18 Oct 2019 15:13:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191018/5928e55b/attachment-0001.html>