[Asterisk-code-review] res_pjsip_mwi: use an ao2_global object for mwi containers (...asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/12998 )

Change subject: res_pjsip_mwi: use an ao2_global object for mwi containers
......................................................................


Patch Set 1:

Sorry I don't have time to do a complete review but I think you need to add `ast_module_shutdown_ref` at the end of load_module right before it returns success.  This bug shows that something has callbacks into res_pjsip_mwi without holding a module reference so CLI `module unload res_pjsip_mwi` could cause a crash.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/12998
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I8f812286dc19a34916acacd71ce2ec26e1042047
Gerrit-Change-Number: 12998
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Corey Farrell <git at cfware.com>
Gerrit-Comment-Date: Wed, 02 Oct 2019 16:32:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191002/badcc479/attachment.html>