[Asterisk-code-review] res_pjsip_t38: T.38 error correction mode selection at 200 ok received (asterisk[13])

[Salah Ahmed]

Salah Ahmed has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13180 )

Change subject: res_pjsip_t38: T.38 error correction mode selection at 200 ok received
......................................................................


Patch Set 2:

(2 comments)

Hello Kevin,
Yeah we can apply the same logic for this side also. Actually we check for initiator because we only want to apply the logic on SDP answer if we receive a RE-INVITE, we want to try our best to honor the offer. 
Thank you,
Salah

https://gerrit.asterisk.org/c/asterisk/+/13180/1/res/res_pjsip_t38.c 
File res/res_pjsip_t38.c:

https://gerrit.asterisk.org/c/asterisk/+/13180/1/res/res_pjsip_t38.c@705 
PS1, Line 705: 			if (session->t38state == T38_LOCAL_REINVITE) {
> Does initiator matter? It seems like we'd want to do the same for any negotiation scenario? Meaning  […]
we check for initiator because we only want to apply the logic on SDP answer
if we receive an RE-INVITE, we want to try our best to honor the offer


https://gerrit.asterisk.org/c/asterisk/+/13180/2/res/res_pjsip_t38.c 
File res/res_pjsip_t38.c:

https://gerrit.asterisk.org/c/asterisk/+/13180/2/res/res_pjsip_t38.c@723 
PS2, Line 723: 			} else {
             : 				if (!pj_stricmp2(&attr->value, "t38UDPRedundancy")) {
             : 					ast_udptl_set_error_correction_scheme(session_media->udptl, UDPTL_ERROR_CORRECTION_REDUNDANCY);
             : 				} else if (!pj_stricmp2(&attr->value, "t38UDPFEC")) {
             : 					ast_udptl_set_error_correction_scheme(session_media->udptl, UDPTL_ERROR_CORRECTION_FEC);
             : 				} else {
             : 					ast_udptl_set_error_correction_scheme(session_media->udptl, UDPTL_ERROR_CORRECTION_NONE);
             : 				}
             : 			}
> Wouldn't the same logic you added above apply if the incoming SDP is from the remote re-invite?
we check for initiator because we only want to apply the logic on SDP answer
if we receive an RE-INVITE, we want to try our best to honor the offer



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13180
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I343c62253ea4c8b7ee17abbfb377a4d484a14b19
Gerrit-Change-Number: 13180
Gerrit-PatchSet: 2
Gerrit-Owner: Salah Ahmed <txrubel at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 21 Nov 2019 00:37:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191120/38d63fb5/attachment-0001.html>