[Asterisk-code-review] app_amd: Fixed timeout issue (asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13161 )

Change subject: app_amd: Fixed timeout issue
......................................................................


Patch Set 5: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/c/asterisk/+/13161/5/apps/app_amd.c 
File apps/app_amd.c:

https://gerrit.asterisk.org/c/asterisk/+/13161/5/apps/app_amd.c@308 
PS5, Line 308: 				ast_verb(3, "AMD: Channel [%s]. No audio date recieved in [%d] seconds.\n", ast_channel_name(chan), totalAnalysisTime);
"date recieved" -> "data received"


https://gerrit.asterisk.org/c/asterisk/+/13161/5/apps/app_amd.c@317 
PS5, Line 317: 		if (f->frametype == AST_FRAME_VOICE || f->frametype == AST_FRAME_CNG) {
Was removing the "f->frametype == AST_FRAME_NULL" intentional?


https://gerrit.asterisk.org/c/asterisk/+/13161/5/apps/app_amd.c@319 
PS5, Line 319:                         audioFrameCount++;
Too much leading whitespace. Should be lined up with the comment on the previous line.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13161
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I642a21b02d389b17e40ccd5357754b034c3daa42
Gerrit-Change-Number: 13161
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Cargile <mikec at vicidial.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Wed, 13 Nov 2019 16:34:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191113/d0534183/attachment.html>